Wireshark-commits: [Wireshark-commits] master-2.6 6bc74bd: Qt: Set the ByteViewText field and proto
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 07 Jun 2018 20:22:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6bc74bd044aae70ac2834eba568409256b950111
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

6bc74bd by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Set the ByteViewText field and protocol foreground.
    
    Set a foreground color when we add a field and protocol format range. On
    some systems the highlight background is darker or lighter than the
    normal background, and we need to adjust the foreground to match.
    
    Add a note about correctly handling our hover rect color.
    
    Change-Id: Ib6b50403dec889280eb3d27f3deb10150d22a599
    Reviewed-on: https://code.wireshark.org/review/28076
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 0882e94cff6a6a5087bfaf3883c9842cb8f9d944)
    Reviewed-on: https://code.wireshark.org/review/28087
    

Actions performed:

    from  06c8101   MTP3: Have prototype parameter names match the implementation
    adds  6bc74bd   Qt: Set the ByteViewText field and protocol foreground.


Summary of changes:
 ui/qt/widgets/byte_view_text.cpp | 4 ++++
 1 file changed, 4 insertions(+)