Wireshark-commits: [Wireshark-commits] master-2.4 f5a84aa: Correctly handle the PPI GPS timestamp f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 06 Jun 2018 18:13:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f5a84aa5ff9229fc886d4d47c90814aa8fc98bb7
Submitter: Jaap Keuter (jaap.keuter@xxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

f5a84aa by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Correctly handle the PPI GPS timestamp fraction
    
    The timestamp and timestamp fraction are processed in one step,
    since this creates a proper timestamp interpretation. There are
    two fixes to this code to deal with erroneous packets.
    One is that when taking into account the timestamp fragment the
    available data must be 8 bytes in total, not just 4.
    The other is that when the mask indicates that there's only a
    timestamp fraction, nothing was shown.
    
    Change-Id: I4a0a65229f322ad56673a26ff6b3e769e994062d
    Signed-off-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/28007
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 447ffdf042e0eebf87ea9d33a9823e6d24345a0e)
    Reviewed-on: https://code.wireshark.org/review/28053
    

Actions performed:

    from  baa51c1   Make sure proto_tree_add_expert items are always added to the tree.
    adds  f5a84aa   Correctly handle the PPI GPS timestamp fraction


Summary of changes:
 epan/dissectors/packet-ppi-gps.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)