Wireshark-commits: [Wireshark-commits] master-2.2 4bf6faf: Don't use FT_STRING fields for non-strin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 05 Jun 2018 04:32:37 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4bf6faf5b6f127c182db80e7f0a3efef522ad10a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

4bf6faf by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use FT_STRING fields for non-strings.
    
    If you're reporting an error, use an expert info item.
    
    If you're putting a structure into the protocol tree, use FT_NONE for
    the structure as a whole.
    
    (In 2.2, we're not doing all of them; in later releases, a significant
    restructuring was done, which eliminated many of them.)
    Change-Id: Ie89b552576b15195acb0a9108d33430115d99f00
    Reviewed-on: https://code.wireshark.org/review/28024
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 8e7396edb4b4ac9580cdddb4feb0903da071905f)
    Reviewed-on: https://code.wireshark.org/review/28027
    

Actions performed:

    from  8138e87   Remove debugging hacks for bug 14738.
    adds  4bf6faf   Don't use FT_STRING fields for non-strings.


Summary of changes:
 epan/dissectors/packet-ieee80211.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)