Wireshark-commits: [Wireshark-commits] master 447ffdf: Correctly handle the PPI GPS timestamp fract
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 05 Jun 2018 04:16:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=447ffdf042e0eebf87ea9d33a9823e6d24345a0e
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

447ffdf by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Correctly handle the PPI GPS timestamp fraction
    
    The timestamp and timestamp fraction are processed in one step,
    since this creates a proper timestamp interpretation. There are
    two fixes to this code to deal with erroneous packets.
    One is that when taking into account the timestamp fragment the
    available data must be 8 bytes in total, not just 4.
    The other is that when the mask indicates that there's only a
    timestamp fraction, nothing was shown.
    
    Change-Id: I4a0a65229f322ad56673a26ff6b3e769e994062d
    Signed-off-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/28007
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8e7396e   Don't use FT_STRING fields for non-strings.
    adds  447ffdf   Correctly handle the PPI GPS timestamp fraction


Summary of changes:
 epan/dissectors/packet-ppi-gps.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)