Wireshark-commits: [Wireshark-commits] master-2.2 fd137f1: clean up tvb_get_guintvar() a bit more
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 03 Jun 2018 17:29:11 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd137f10e1ff47922a5e95ac1497b0bb7621c4ac
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

fd137f1 by Martin Kaiser (wireshark@xxxxxxxxx):

    clean up tvb_get_guintvar() a bit more
    
    Wrap long lines.
    
    Use a do-while loop. We know up-front that we'll go into the loop at
    least once. Remove the cont variable, use the exit condition directly.
    
    Set *octetCount = 0 if we return 0 because of an error. In that case, we
    did not process any bytes and should inform the caller about this.
    
    Change-Id: I222270939e42e0096b6f5a25b197bd4bae12235e
    Reviewed-on: https://code.wireshark.org/review/26245
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 4630b4fcf835b91d043ad12818d666c7321e28a4)
    Reviewed-on: https://code.wireshark.org/review/27997
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ae392a7   wap: include stdio.h
    adds  fd137f1   clean up tvb_get_guintvar() a bit more


Summary of changes:
 epan/dissectors/packet-wap.c | 47 ++++++++++++++++++++++++--------------------
 1 file changed, 26 insertions(+), 21 deletions(-)