Wireshark-commits: [Wireshark-commits] master-2.2 418d0c9: And removing the DISSECTOR_ASSERT() chec
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 02 Jun 2018 19:23:07 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=418d0c912be0735bbb9351212a3edd615a803383
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

418d0c9 by Guy Harris (guy@xxxxxxxxxxxx):

    And removing the DISSECTOR_ASSERT() checks brought bug 14738 back.
    
    Un-remove them, *and* try to force a TShark abort if the check fails, to
    see if that forces a failure with an error message indicating which
    check failed.
    
    Change-Id: I9642dff0b90ee0a56163c55e092722f3b9b5bd13
    Reviewed-on: https://code.wireshark.org/review/27959
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 8f1afb13a829620c9fb3ba59342786bc1bd1d0b1)
    Reviewed-on: https://code.wireshark.org/review/27960
    

Actions performed:

    from  17953b3   That change appeared to have "fixed" bug 14738.
    adds  418d0c9   And removing the DISSECTOR_ASSERT() checks brought bug 14738 back.


Summary of changes:
 epan/dissectors/packet-mmse.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)