Wireshark-commits: [Wireshark-commits] master c9ba7c9: CIP: Use a struct for connection triad
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 01 Jun 2018 05:53:22 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c9ba7c95dfe16c55affc47741cea533866b2dc70
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c9ba7c9 by Dylan Ulis (daulis0@xxxxxxxxx):

    CIP: Use a struct for connection triad
    
    1. Connection Serial Number, Vendor ID, and Device Serial Number are always
    used as a group. Group these as a struct to make them easier to manage.
    2. Pull out common code into dissect_connection_triad()
    
    No functional changes.
    
    Change-Id: Ide126f8d0ea6ab8e2de5abf20e12643d5a35924d
    Reviewed-on: https://code.wireshark.org/review/27926
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a7c244e   Don't assume an HTTP header doesn't contain a NUL.
    adds  c9ba7c9   CIP: Use a struct for connection triad


Summary of changes:
 epan/dissectors/packet-cip.c       | 146 +++++++++++++++++++------------------
 epan/dissectors/packet-cip.h       |  14 ++--
 epan/dissectors/packet-cipsafety.c |  67 ++++++++---------
 epan/dissectors/packet-enip.c      |  41 ++++-------
 epan/dissectors/packet-enip.h      |   8 +-
 5 files changed, 132 insertions(+), 144 deletions(-)