Wireshark-commits: [Wireshark-commits] master ff28818: mysql: fix packet length calculation
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 31 May 2018 04:40:27 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ff2881808865b68bed20534cb3fcdc6844575063
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ff28818 by Peter Wu (peter@xxxxxxxxxxxxx):

    mysql: fix packet length calculation
    
    Instead of relying on heuristics (single TCP segment contains a whole
    MySQL packet) use the compression state from the greeting. This fixes
    bad dissection when a single TCP segment contains multiple MySQL packets
    with three other bytes at the end.
    
    Tested with the capture from the linked report as well as bug 10342.
    
    Bug: 13754
    Change-Id: I9d9573f4705265d78ec3d75a195df70718de77b3
    Reviewed-on: https://code.wireshark.org/review/27916
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d8c19f8   CMake: clarify that perl is mandatory
    adds  ff28818   mysql: fix packet length calculation


Summary of changes:
 epan/dissectors/packet-mysql.c | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)