Wireshark · Wireshark-commits: [Wireshark-commits] master-2.6 abcfec4: Qt: select a better default Decode As table

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=abcfec4be118bf061bcebdbc040cea1c90a260c3
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

abcfec4 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: select a better default Decode As table
    
    USB has three possible tables, usb.device, usb.product and usb.protocol
    (shown in that order in the Decode As dialog). For single packets with
    no prior device descriptors, the last two tables have no valid selector
    (integer zero). In such cases it seems more reasonable to use tables for
    which a valid selector exists (for example, "usb.device").
    
    Bug: 14717
    Change-Id: I2319817fa11318a97519d8cfc912343b16224c12
    Reviewed-on: https://code.wireshark.org/review/27820
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit ea763a96387d9f56d5325d5dcd96048666636aab)
    Reviewed-on: https://code.wireshark.org/review/27890
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  e84f5f8   wsutil: fix compilation on freebsd.
    adds  abcfec4   Qt: select a better default Decode As table


Summary of changes:
 ui/qt/models/decode_as_model.cpp | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)