Wireshark · Wireshark-commits: [Wireshark-commits] master-2.2 24c3030: mmse: remove a ton of if (tree) checks

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=24c30307b8fae2cde1ef6422ebb773d24ffbab3e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

24c3030 by Martin Kaiser (wireshark@xxxxxxxxx):

    mmse: remove a ton of if (tree) checks
    
    Keep the "global" check where the entire processing was under if (tree).
    Move this check in front of the while loop and exit if we have no tree.
    
    Remove the subsequent (duplicate) checks for indivial
    proto_tre_add_...() calls.
    
    Change-Id: I6b978b438b9f1c84c8927ae4eb9c53a8eaadb4ef
    Reviewed-on: https://code.wireshark.org/review/26246
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit b70eb189bb906d0b03ca95219a4c9c82eee43f97)
    Reviewed-on: https://code.wireshark.org/review/27887
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  b0b4147   wsutil: fix compilation on freebsd.
    adds  24c3030   mmse: remove a ton of if (tree) checks


Summary of changes:
 epan/dissectors/packet-mmse.c | 1009 +++++++++++++++++++----------------------
 1 file changed, 472 insertions(+), 537 deletions(-)