Wireshark · Wireshark-commits: [Wireshark-commits] master-2.6 a42dbe8: SCTP: fix crash when filtering an association

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a42dbe842cb5a752a9889e909db11058ea45f62c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

a42dbe8 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    SCTP: fix crash when filtering an association
    
    Do not free a tsn_t element if it has already been inserted in a GList.
    The code structure is complex enough to add an explicit check before
    calling g_free().
    Fixes a regression introduced in gb19ca06fcc.
    
    While we are at it, let's call the correct free function and plug some
    memory leaks.
    
    Bug: 14733
    Change-Id: I071da96982da569083fd98b790e0d37ac0826ff1
    Reviewed-on: https://code.wireshark.org/review/27808
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 06879e89c04ed8edf7c9a02805ff0adf781bf151)
    Conflicts:
            ui/tap-sctp-analysis.c
    Reviewed-on: https://code.wireshark.org/review/27865
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  b7125bc   ICMPv6: fix wrong tree for some bitmask field
    adds  a42dbe8   SCTP: fix crash when filtering an association


Summary of changes:
 ui/tap-sctp-analysis.c | 65 ++++++++++++++++++++++++++++----------------------
 ui/tap-sctp-analysis.h |  2 +-
 2 files changed, 37 insertions(+), 30 deletions(-)