Wireshark-commits: [Wireshark-commits] master 5b30d5c: Have a dissector table for SSL/TLS/DTLS ALPN
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 27 May 2018 01:43:41 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5b30d5c7675fd03a420257c334808549eddc6e7e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5b30d5c by Guy Harris (guy@xxxxxxxxxxxx):

    Have a dissector table for SSL/TLS/DTLS ALPN protocol IDs.
    
    Have dissectors register with their protocol ID string in that table,
    rather than having a table in epan/dissectors/packet-ssl-utils.c that
    has to be updated for new protocols.
    
    Have a table of protocol ID string prefixes, to handle the case of
    protocols such as SPDY and HTTP2 drafts, where multiple protocol IDs are
    used for different versions.
    
    Change-Id: I363d04895a88e779fbbca7dc8e1f31aa1970a31a
    Reviewed-on: https://code.wireshark.org/review/27836
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  53a3736   Fix 802.11ax fields.
    adds  5b30d5c   Have a dissector table for SSL/TLS/DTLS ALPN protocol IDs.


Summary of changes:
 epan/dissectors/packet-dtls.c        |   4 ++
 epan/dissectors/packet-http.c        |   6 ++
 epan/dissectors/packet-http2.c       |   6 ++
 epan/dissectors/packet-ssl-utils.c   | 116 +++++++++++++++++++----------------
 epan/dissectors/packet-ssl-utils.h   |   8 +++
 epan/dissectors/packet-ssl.c         |   4 ++
 epan/dissectors/packet-stun.c        |   7 +++
 epan/dissectors/packet-turnchannel.c |   7 +++
 8 files changed, 104 insertions(+), 54 deletions(-)