Wireshark-commits: [Wireshark-commits] master 06879e8: SCTP: fix crash when filtering an associatio
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 26 May 2018 11:24:03 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=06879e89c04ed8edf7c9a02805ff0adf781bf151
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

06879e8 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    SCTP: fix crash when filtering an association
    
    Do not free a tsn_t element if it has already been inserted in a GList.
    The code structure is complex enough to add an explicit check before
    calling g_free().
    Fixes a regression introduced in gb19ca06fcc.
    
    While we are at it, let's call the correct free function and plug some
    memory leaks.
    
    Bug: 14733
    Change-Id: I071da96982da569083fd98b790e0d37ac0826ff1
    Reviewed-on: https://code.wireshark.org/review/27808
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  0e51723   Added support for extended length BACnet MS/TP data frames.
    adds  06879e8   SCTP: fix crash when filtering an association


Summary of changes:
 ui/tap-sctp-analysis.c | 80 ++++++++++++++++++++++++++++++++------------------
 ui/tap-sctp-analysis.h |  2 +-
 2 files changed, 52 insertions(+), 30 deletions(-)