Wireshark-commits: [Wireshark-commits] master c4c5ad2: ieee80211: Make DMG Capabilities dissection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 24 May 2018 17:58:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c4c5ad26865ab45bbac647b165aef6f4728b3639
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c4c5ad2 by Richard Sharpe (realrichardsharpe@xxxxxxxxx):

    ieee80211: Make DMG Capabilities dissection handle earlier formats
    
    The recent changes to support the current 22-byte DMC Capabilities IE
    defined in IEEE802.11-2012 prevents Wireshark from handling frames
    in the earlier format.
    
    This change allows Wireshark to dissect both the earlier and current
    formats but gives an error if the IE does not have a length of 22.
    
    The error could perhaps be demoted to a warning.
    
    Also made a minor correction to the header fields to conform with
    other uses.
    
    Bug: 14727
    Change-Id: I3dc333b273f915fa5f5f4cc5c13c1b84863b6713
    Reviewed-on: https://code.wireshark.org/review/27782
    Petri-Dish: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  ca434b1   PDCP NR: add a framing option to indicate MAC-I presence in user plane PDU (CID 1435480)
    adds  c4c5ad2   ieee80211: Make DMG Capabilities dissection handle earlier formats


Summary of changes:
 epan/dissectors/packet-ieee80211.c | 28 ++++++++++++++++++++++------
 1 file changed, 22 insertions(+), 6 deletions(-)