Wireshark-commits: [Wireshark-commits] master 790d490: CMake: remove GIT_BIN_PARAM
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 24 May 2018 04:15:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=790d4902496f8dcec54d83e34b6674701ac4f981
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

790d490 by Joakim Karlsson (oakimk@xxxxxxxxx):

    CMake: remove GIT_BIN_PARAM
    
    Added in adb731c1cd69855b1655a0f23001655392a07340 but never worked,
    and later corrected in e21da738262af2ba6cf72f46fdc045f0337ca27e.
    Correction however gave cygwin user problems with the perl optional parameter
    which droped qoutes around the path. But since the orginal commit never worked
    as intended in the beginning, it's assume safe to remove.
    
    Change-Id: I825a4e53b257d47601c330b210ac5ffb6870e0d9
    Reviewed-on: https://code.wireshark.org/review/27758
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1b6c702   Qt: Support search without a selected packet
    adds  790d490   CMake: remove GIT_BIN_PARAM


Summary of changes:
 CMakeLists.txt  |  5 -----
 make-version.pl | 18 ++++++++----------
 2 files changed, 8 insertions(+), 15 deletions(-)