Wireshark-commits: [Wireshark-commits] master c159d48: maxmind: Move request processing to a thread
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 24 May 2018 04:07:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c159d48420e184f068ed6cea1715ab697fda4f7d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c159d48 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    maxmind: Move request processing to a thread.
    
    It's possible to block while we're writing to our mmdbresolve pipe,
    particularly on Windows. Move the write to a separate thread.
    
    Add an #ifdef to mmdbresolve.c which helps test blocking.
    
    Bug: 14701
    Change-Id: I6cb8a46a190a268da64f1e6f54d1052d03743c95
    Reviewed-on: https://code.wireshark.org/review/27750
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  dcececa7  ieee80211: Make QoS DSCP Exception and Range descriptions searchable.
    adds  c159d48   maxmind: Move request processing to a thread.


Summary of changes:
 epan/maxmind_db.c | 119 +++++++++++++++++++++++++++++++++++++++---------------
 mmdbresolve.c     |  15 +++++++
 2 files changed, 101 insertions(+), 33 deletions(-)