Wireshark-commits: [Wireshark-commits] master 5ccac2b: NBAP: Simplify private data API
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 May 2018 17:51:05 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5ccac2b65af39fe778aec9a3ed83c502dc6023d3
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5ccac2b by Darien Spencer (cusneud@xxxxxxxx):

    NBAP: Simplify private data API
    
    Explicit getters/setters seems excessive and become
    unmaintainable when the private data struct gets big, like in NBAP
    
    Change-Id: I54d6eea327f1b393d9f80aafcbdd75080e10d50d
    Reviewed-on: https://code.wireshark.org/review/27749
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  14b2d4c   Add asciidoctor and asciidoctor-pdf to macos-setup.sh
    adds  5ccac2b   NBAP: Simplify private data API


Summary of changes:
 epan/dissectors/asn1/nbap/nbap.cnf               |  585 +++++-----
 epan/dissectors/asn1/nbap/packet-nbap-template.c |  398 +------
 epan/dissectors/packet-nbap.c                    | 1240 +++++++---------------
 3 files changed, 670 insertions(+), 1553 deletions(-)