Wireshark-commits: [Wireshark-commits] master-2.6 e37b2c4: Do IP address resolution synchronously b
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 May 2018 03:52:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e37b2c432c0bcdba757dc19c4d635c28606f0253
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

e37b2c4 by Guy Harris (guy@xxxxxxxxxxxx):

    Do IP address resolution synchronously before printing in TShark.
    
    Otherwise, the first N packets printed, for a value of N dependent on
    various factors, won't get IP addresses resolved to names, even if the
    user wants them resolved.  Unlike Wireshark, which, when a name is
    resolved in asynchronously, can go back and fix up the displayed packet
    when the asynchronous operation completes, once TShark has written
    packet data to the standard output, it can't go back and fix it if it
    did name resolution asynchronously.
    
    Bug: 14711
    Change-Id: I8ebbd83103e5780c903b5560e01b7b92fa39c924
    Reviewed-on: https://code.wireshark.org/review/27668
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 0542c5b7009e4b6cd4e7760a504b16e30b6b3bf4)
    Reviewed-on: https://code.wireshark.org/review/27734
    

Actions performed:

    from  f0e98f9   Creat protocol tvbuff before allocating and freeing memory.
    adds  e37b2c4   Do IP address resolution synchronously before printing in TShark.


Summary of changes:
 epan/addr_resolv.c | 223 +++++++++++++++++++++++++++++++++++++++++++++++++----
 epan/addr_resolv.h |   8 ++
 tshark.c           |  35 +++++----
 3 files changed, 234 insertions(+), 32 deletions(-)