Wireshark · Wireshark-commits: [Wireshark-commits] master 644939e: CMake: try to fix duplicate qm builds on Windows

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=644939ed9e4e5449970e27a674a6936723daed5c
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

644939e by Peter Wu (peter@xxxxxxxxxxxxx):

    CMake: try to fix duplicate qm builds on Windows
    
    The Windows buildbot showed that .qm files are generated twice. This
    resulted in rebuilding i18n.cpp, which resulted in rebuilding qtui,
    which finally resulted in Wireshark.exe being built twice for no reason.
    
    Assuming it is the same issue as commit v2.3.0rc0-3078-gaa9a0b3bf8,
    avoid having multiple targets depend on the same output (.qm files).
    This patch requires CMake 3.1 or newer.
    
    Change-Id: Iffd8946701553b89c09504278afa4b16d2a0b5b4
    Fixes: v2.5.0rc0-1366-gdfa893b1cf ("cmake: set CMAKE_AUTOUIC and CMAKE_AUTORCC to avoid CMP0071 warning")
    Reviewed-on: https://code.wireshark.org/review/27620
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  64ef1ca   radius: fix memleaks in dissect_attribute_value_pairs
    adds  644939e   CMake: try to fix duplicate qm builds on Windows


Summary of changes:
 ui/qt/CMakeLists.txt | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)