Wireshark-commits: [Wireshark-commits] master-2.4 22a0f45: Don't bother with CMAKE_C_STANDARD.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 16 May 2018 17:18:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=22a0f459ad4823fcf9caa85cb0456b5ad741d385
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

22a0f45 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't bother with CMAKE_C_STANDARD.
    
    It was introduced in CMake 3.1, so, unless we require CMake 3.1 or
    later, we'd have to manually try to enable C99 support on pre-3.1
    releases, so we might as well just do it manually all the time - it's
    not clear that CMAKE_C_STANDARD does it much better, especially give
    that, for example, it wasn't until CMake 3.9 that support for enabling
    C99 support in IBM XL C was added.
    
    Change-Id: I51038b90fd3d8ab5050c5da4441765b19db9091b
    Reviewed-on: https://code.wireshark.org/review/26648
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    (cherry picked from commit 35fed45a831e44e940b123b2ed2a3fbe1b70b21d)
    Reviewed-on: https://code.wireshark.org/review/27583
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  b1ed9a8   Add missing docbook graphics files to the CMake file.
    adds  22a0f45   Don't bother with CMAKE_C_STANDARD.


Summary of changes:
 CMakeLists.txt | 85 +++++++++++++++++++++++++++++++++++++---------------------
 1 file changed, 54 insertions(+), 31 deletions(-)