Wireshark-commits: [Wireshark-commits] master-2.4 c79b342: gsm_a_dtap: fix off-by-one buffer overfl
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 15 May 2018 13:37:08 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c79b342aa75fe8fa51aed20e00a07ca6d6438585
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

c79b342 by Peter Wu (peter@xxxxxxxxxxxxx):

    gsm_a_dtap: fix off-by-one buffer overflow (write)
    
    The output buffer needs one more byte for the string terminator.
    
    Bug: 14688
    Change-Id: I7d606aa8fb769fd65ba894f0472ada3543a1e3cd
    Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=6420
    Reviewed-on: https://code.wireshark.org/review/27539
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 48fac2a18debb2969413e03f3d88bbb9c31500ae)
    Reviewed-on: https://code.wireshark.org/review/27559
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  ac55e80   tvbuff: make tvb_bytes_exist fail with negative values
    adds  c79b342   gsm_a_dtap: fix off-by-one buffer overflow (write)


Summary of changes:
 epan/dissectors/packet-gsm_a_dtap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)