Wireshark-commits: [Wireshark-commits] master 748c569f: Clean up Qt installation.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 15 May 2018 03:26:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=748c569f88308f38b98678d5566f16706f6a3e07
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

748c569f by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up Qt installation.
    
    We don't support 32-bit builds on macOS, so get rid of the now-unused
    TARGET_PLATFORM variable and the comment about how to build 32-bit
    libraries.
    
    Follow the complex rules that Qt's download directories unfortunately
    require to get the .dmg for a given release.  Drop support for
    installing Qt 4.
    
    CMake doesn't use pkg-config to find the Qt frameworks, so we don't need
    to fix up the .pc files (which aren't even shipped with later versions
    of Qt).
    
    Change-Id: I5edc69f8b34dac47bb2310689f296ce37347f495
    Reviewed-on: https://code.wireshark.org/review/27542
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  67b9ccd   Update a comment.
    adds  748c569f  Clean up Qt installation.


Summary of changes:
 tools/macos-setup.sh | 142 ++++++++++++++++++++++++++++++++++-----------------
 1 file changed, 96 insertions(+), 46 deletions(-)