Wireshark-commits: [Wireshark-commits] master-2.2 4425716: dns: fix null pointer deref for empty na
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 14 May 2018 13:29:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4425716ddba99374749bd033d9bc0f4add2fb973
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

4425716 by Peter Wu (peter@xxxxxxxxxxxxx):

    dns: fix null pointer deref for empty name in SRV record
    
    Per RFC 2782, the name should follow the "_Service._Proto.Name" format.
    If a malformed packet does not adhere to this and provides a zero-length
    name, then wmem_strsplit returns NULL.
    
    Bug: 14681
    Change-Id: I7b9935238a9800a1526c8b694fd2c63d3b488d0b
    Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7416
    Reviewed-on: https://code.wireshark.org/review/27499
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 843735e0efe03f601ed69f69e5295974aad927b2)
    Reviewed-on: https://code.wireshark.org/review/27532
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  5f8bd0c   DNS: replace g_strsplit by wmem_strsplit
    adds  4425716   dns: fix null pointer deref for empty name in SRV record


Summary of changes:
 epan/dissectors/packet-dns.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)