Wireshark-commits: [Wireshark-commits] master d80dbe5: Display configured checksum Expert summary s
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 14 May 2018 08:15:52 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d80dbe533cb927ca16912c6ca9dead2d165362e9
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d80dbe5 by Dylan Ulis (daulis0@xxxxxxxxx):

    Display configured checksum Expert summary string
    
    Previously, checksum code would override the expert_field summary
    string configured by dissectors, and display the generic "Bad checksum"
    string in the Expert Information dialog.
    
    This change uses the configured expert_field summary string instead.
    eg: "CRC-S1 incorrect [should be 0xff]" instead of "Bad checksum [should
    be 0xff]"
    
    This fixes problem #2 in the linked bug.
    
    Bug: 14425
    Change-Id: I168b2be92ec2d8d6f956beeaf6292574bc1d9dab
    Reviewed-on: https://code.wireshark.org/review/25758
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  843735e   dns: fix null pointer deref for empty name in SRV record
    adds  d80dbe5   Display configured checksum Expert summary string


Summary of changes:
 epan/dissectors/packet-cipsafety.c | 6 +++---
 epan/proto.c                       | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)