Wireshark · Wireshark-commits: [Wireshark-commits] master 3a1bf2b: Use ws_g_warning() for plugin registration errors.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a1bf2b87e2677a17d4a6d3844726613d214e6b8
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3a1bf2b by Guy Harris (guy@xxxxxxxxxxxx):

    Use ws_g_warning() for plugin registration errors.
    
    Those should always be reported, as they indicate that a block type
    plugin is trying to do something we don't allow.
    
    We should probably have a mechanism by which ws_g_warning() messages are
    logged to the standard error for command-line programs, logged to an
    error message window for GUI programs, and logged to some form of system
    log for daemons.  For now, it's a good way to log non-fatal errors that
    should always be shown in *some* fashion, as well as to mark messages
    that should be handled in the form described in the previous sentence.
    
    Change-Id: Ieedf87fc2dd3184a4466ae69af01f799165c1b70
    Reviewed-on: https://code.wireshark.org/review/27519
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6dedca3   wiretap: use pcapng_debug instead of g_warning.
    adds  3a1bf2b   Use ws_g_warning() for plugin registration errors.


Summary of changes:
 wiretap/pcapng.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)