Wireshark-commits: [Wireshark-commits] master a2376d2: batadv: Check checksum for full TT responses
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 13 May 2018 16:17:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a2376d27d72c1363d0b6500ad6f8c3bd0826ba01
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a2376d2 by Sven Eckelmann (sven@xxxxxxxxxxxxx):

    batadv: Check checksum for full TT responses
    
    The full translation table responses for the v15 format of batman-adv
    contain a list of vlans and then a list of entries for these VLANs. The
    VLANs itself contain a checksum that is done over the entries which belong
    to these VLANs.
    
    The checkum must be correct or otherwise the receiver will not be able to
    finish its synchronization of the remote translation table. Having this
    information available for filtering is essential to understand such a
    situation and to analyze why a node continues to send full table
    requests.
    
    Change-Id: I90f3d3d2c19ac85c1c5a6474cf1877583cfd1139
    Signed-off-by: Sven Eckelmann <sven@xxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/27442
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  4a89575   batadv: Accept Multicast TVLV v2
    adds  a2376d2   batadv: Check checksum for full TT responses


Summary of changes:
 epan/dissectors/packet-batadv.c | 99 ++++++++++++++++++++++++++++++++++++++---
 1 file changed, 92 insertions(+), 7 deletions(-)