Wireshark-commits: [Wireshark-commits] master 03a8e01: CIP: Data Type updates
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 11 May 2018 20:37:43 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=03a8e01cfcc4ee8699f15b1ca41de6f63c6ae71e
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

03a8e01 by Dylan Ulis (daulis0@xxxxxxxxx):

    CIP: Data Type updates
    
    1. Convert lots of things to use the new BASE_UNIT_STRING feature
    2. ANSI Symbol: Print size correctly in generated response
    3. Attribute Status is a 1 byte value in Get/Set_Attribute_Lists
    4. Forward Open: Indicate this is a Safety connection in info column. This is useful because Safety connections aren't obvious from the CIP Class like other connections (eg: Motion)
    
    Change-Id: I8cb00fd0141d75a3e9425d8e618b1f54d12807be
    Reviewed-on: https://code.wireshark.org/review/27447
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  91d173e   MAC LTE: fix mac-lte.slsch.format field
    adds  03a8e01   CIP: Data Type updates


Summary of changes:
 epan/dissectors/packet-cip.c | 102 +++++++++++++++++++++----------------------
 1 file changed, 49 insertions(+), 53 deletions(-)