Wireshark-commits: [Wireshark-commits] master aedc1c7: NSIS: Modernize the installer and remove GTK
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 11 May 2018 15:20:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aedc1c7e4911347057bf69a5026a717fb8576064
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

aedc1c7 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    NSIS: Modernize the installer and remove GTK+ entries.
    
    Migrate the Additional Tasks page to nsDialog. Create it using NSIS
    Dialog Designer.
    
    Migrate the Modern UI code (WinPcapPage.ini and USBPcapPage.ini) to
    Modern UI2.
    
    Use LogicLib flow control instead of Gotos+labels in more places.
    
    Change-Id: I1a3733f0202ca372456074f43e5ae23b1da4e1b9
    Reviewed-on: https://code.wireshark.org/review/27449
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  ff90e30   WiX: Remove remaining GTK+ content.
    adds  aedc1c7   NSIS: Modernize the installer and remove GTK+ entries.


Summary of changes:
 .editorconfig                             |   5 +
 packaging/nsis/AdditionalTasksPage.ini    | 125 -----------
 packaging/nsis/AdditionalTasksPage.nsddef |  17 ++
 packaging/nsis/AdditionalTasksPage.nsdinc |  76 +++++++
 packaging/nsis/common.nsh                 |   8 +-
 packaging/nsis/config.nsh.in              |   2 -
 packaging/nsis/wireshark.nsi              | 336 +++++++++++++-----------------
 7 files changed, 248 insertions(+), 321 deletions(-)
 delete mode 100644 packaging/nsis/AdditionalTasksPage.ini
 create mode 100644 packaging/nsis/AdditionalTasksPage.nsddef
 create mode 100644 packaging/nsis/AdditionalTasksPage.nsdinc