Wireshark-commits: [Wireshark-commits] master 695fdab: nettrace: add g_assert in write_packet_data
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 10 May 2018 10:10:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=695fdaba95c51b44d42f119dbb728ef3f28d0609
Submitter: Dario Lombardo (lomato@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

695fdab by Dario Lombardo (lomato@xxxxxxxxx):

    nettrace: add g_assert in write_packet_data (CID 1435482).
    
    proto_col_str could have been nulled by line 409, but in that case
    EXP_PDU_TAG_COL_PROT_BIT is not set, then strlen doesn't get called in
    line 432. Coverity raised a false positive and g_assert will pacify it.
    
    Change-Id: Ib22868a549319913c9c2a25ede0b63fed3af6eb0
    Reviewed-on: https://code.wireshark.org/review/27424
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    

Actions performed:

    from  9a30bad   gitignore: add test log files.
    adds  695fdab   nettrace: add g_assert in write_packet_data (CID 1435482).


Summary of changes:
 wiretap/nettrace_3gpp_32_423.c | 2 ++
 1 file changed, 2 insertions(+)