Wireshark-commits: [Wireshark-commits] master e76ca2d: ui/tap-rtp-common: fix some memleaks
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 09 May 2018 18:42:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e76ca2d3cb005d9276c953a14e63523a21cdb8dc
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e76ca2d by Peter Wu (peter@xxxxxxxxxxxxx):

    ui/tap-rtp-common: fix some memleaks
    
    If a stream with the given parameters was already known, the addresses
    and payload_type_name would be leaked. There are potential other leaks
    for rtp_stream_info_t (also in Qt RtpAnalysisDialog::showPlayer), but
    that requires a more careful analysis. Found by Clang Static Analyzer.
    
    Change-Id: I2fb19464b4c0f89d597a7e6117d219111922b4f2
    Reviewed-on: https://code.wireshark.org/review/27346
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  67ea8cb   ui/voip_calls: fix memleak in is_mgcp_signal
    adds  e76ca2d   ui/tap-rtp-common: fix some memleaks


Summary of changes:
 ui/tap-rtp-common.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)