Wireshark-commits: [Wireshark-commits] master-2.4 fe3e09f: proto: don't overrun buffer.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 09 May 2018 14:23:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fe3e09f27a045d3ddface7ef1ae051ae1809c955
Submitter: Dario Lombardo (lomato@xxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

fe3e09f by Dario Lombardo (lomato@xxxxxxxxx):

    proto: don't overrun buffer.
    
    This is shown by a bunch of coverity reports all pointing at this line.
    Every buffer has a ITEM_LABEL_LENGTH, but label_mark_truncated access it
    at ITEM_LABEL_LENGTH (off-by-one).
    
    CIDs:
    1435461
    1435462
    1435465
    1435466
    1435471
    1435472
    1435477
    1435481
    1435483
    1435484
    1435485
    1435489
    1435492
    1435500
    
    Fixes: v1.11.3-rc1-1837-gf94674d2fb ("truncate UTF-8 strings only at the boundary between two characters")
    Change-Id: I3781c36594f7db880bc9f76b64d261dbc498c0ce
    Reviewed-on: https://code.wireshark.org/review/27425
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    (cherry picked from commit 4b6224a67326dc72e428e8f6606b8ae10059c0bd)
    Reviewed-on: https://code.wireshark.org/review/27427
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    

Actions performed:

    from  8716e33   Fix backport.
    adds  fe3e09f   proto: don't overrun buffer.


Summary of changes:
 epan/proto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)