Wireshark-commits: [Wireshark-commits] master-2.6 f056bd3: Fix infinite loop.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 09 May 2018 03:38:39 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f056bd3f884b0a602fb815a4a1839a6c1763956b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

f056bd3 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix infinite loop.
    
    If a variable is a count of items, and we're looping while the count is
    non-zero, we need to decrement it after every item we process.
    
    Fixes Coverity CID 1435501.
    
    Change-Id: Iabb0cb6276d4bcf4b1bdea9ec3ba943dac1b9938
    Reviewed-on: https://code.wireshark.org/review/27402
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 29465751994416552d859bc1be051b5dae48ae0a)
    Reviewed-on: https://code.wireshark.org/review/27403
    

Actions performed:

    from  990ea00   Qt: fix IPv4 GeoIP lookup in endpoints dialog
    adds  f056bd3   Fix infinite loop.


Summary of changes:
 epan/dissectors/packet-ieee80211.c | 1 +
 1 file changed, 1 insertion(+)