Wireshark-commits: [Wireshark-commits] master c1deca1: smb: fix memleak in export objects
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 09 May 2018 03:05:30 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c1deca140141a05d6d6a82b854eafa0f11c21e63
Submitter: ronnie sahlberg (ronniesahlberg@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c1deca1 by Peter Wu (peter@xxxxxxxxxxxxx):

    smb: fix memleak in export objects
    
    "aux_smb_fid_type_string" is used as "%s" argument for g_strdup_printf,
    there is no need to clone it. I checked all calls and "fid_type" should
    always be valid, but in case of a bug, let's not return a NULL pointer
    but "?". Found by Clang Static Analyzer.
    
    Change-Id: I09896638eb5512f22b3d1a227462499e12cedcde
    Reviewed-on: https://code.wireshark.org/review/27349
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
    

Actions performed:

    from  e9c5d93   Windows: prioritize Npcap over WinPcap
    adds  c1deca1   smb: fix memleak in export objects


Summary of changes:
 epan/dissectors/packet-smb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)