Wireshark-commits: [Wireshark-commits] master 4c14ac0: tcp: fix memleak in Follow TCP tap in error
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 05 May 2018 16:13:03 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4c14ac075403e3f5ea5709501918c08e45272439
Submitter: Dario Lombardo (lomato@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4c14ac0 by Peter Wu (peter@xxxxxxxxxxxxx):

    tcp: fix memleak in Follow TCP tap in error cases
    
    If this not the first data segment and the data is somehow empty
    (overlap?) or if the packet is out-of-order, the whole data fragment and
    follow_record_t structure was leaked. Found by Clang Static Analyzer.
    
    Change-Id: I81dc7749c738938b14d2cf4ad41e624b15099da6
    Fixes: v2.3.0rc0-1449-g66fa31415f ("tcp: Fix Follow TCP tap data and when its tapped.")
    Reviewed-on: https://code.wireshark.org/review/27348
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    

Actions performed:

    from  230d7d4   Test: Integrate ftsanity directly into our tests.
    adds  4c14ac0   tcp: fix memleak in Follow TCP tap in error cases


Summary of changes:
 epan/dissectors/packet-tcp.c | 6 ++++++
 1 file changed, 6 insertions(+)