Wireshark-commits: [Wireshark-commits] master ae6afe4: CIP Motion: Attribute Support
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 04 May 2018 06:54:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ae6afe416b07771234334334eecb0feadaaab52f
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ae6afe4 by Dylan Ulis (daulis0@xxxxxxxxx):

    CIP Motion: Attribute Support
    
    1. Add attribute table similar to the other CIP related dissectors. Currently, this just adds 2 attributes. More will come in separate reviews. (Still clarifying some information in the Spec)
    2. Minor wording updates to match spec
    
    Change-Id: I667b8e465d576020471c8e7fc10b43e25ea573dd
    Reviewed-on: https://code.wireshark.org/review/27180
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Petri-Dish: Jim Young <jim.young.ws@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  087cb7d   pfcp: updated UP Function Features IE
    adds  ae6afe4   CIP Motion: Attribute Support


Summary of changes:
 epan/dissectors/packet-cip.c       |  4 +-
 epan/dissectors/packet-cip.h       |  2 +
 epan/dissectors/packet-cipmotion.c | 90 ++++++++++++++++++++++++--------------
 epan/dissectors/packet-cipmotion.h | 19 ++++++++
 4 files changed, 81 insertions(+), 34 deletions(-)
 create mode 100644 epan/dissectors/packet-cipmotion.h