Wireshark-commits: [Wireshark-commits] master f729664: prefs: fix importing some old protocol prefe
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 02 May 2018 04:10:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f7296644c55504318294fab1bd8ffefc50e86292
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f729664 by Peter Wu (peter@xxxxxxxxxxxxx):

    prefs: fix importing some old protocol preferences
    
    Some preference modules did not exist, so importing would not work.
    While vuze-dht used to have a configurable protocol name, it no longer
    supports that, so remove it from the list.
    
    Add some sanity checks to prevent bug 14316 from going undetected again,
    and to ensure that dead code is removed when prefs are removed.
    
    Change-Id: I5df809af66a6c19f9eb9a6b75d5e60c96008cde4
    Fixes: v2.3.0rc0-971-g268841f3e0 ("Combine Decode As and port preferences for tcp.port dissector table.")
    Reviewed-on: https://code.wireshark.org/review/27227
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  58da452   Test: Remove the Bash test scripts.
    adds  f729664   prefs: fix importing some old protocol preferences


Summary of changes:
 epan/prefs.c | 41 +++++++++++++++++++++++++++++------------
 1 file changed, 29 insertions(+), 12 deletions(-)