Wireshark-commits: [Wireshark-commits] master cd94b1c: Force textify.ps1 to read files as UTF-8.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 02 May 2018 04:06:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cd94b1cb8edda0b947e920a1a45c868b254284fd
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cd94b1c by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Force textify.ps1 to read files as UTF-8.
    
    Prior to the switch from AsciiDoc to Asciidoctor we converted
    release_notes.html to NEWS using elinks or lynx, which in turn generated
    ASCII output. It was sufficient to read NEWS in PowerShell using
    Get-Content, which defaults to ASCII.
    
    We now use tools/html2text.py, which generates UTF-8. Switch Get-Content's
    encoding to match. Note that Notepad detects file encodings heuristically,
    and that we might want to use a BOM.
    
    Bug: 14636
    Change-Id: Ibd92ef7ad642631a938bb4d75a2d83f479099032
    Reviewed-on: https://code.wireshark.org/review/27240
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  15f1b0b   mgcp: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
    adds  cd94b1c   Force textify.ps1 to read files as UTF-8.


Summary of changes:
 tools/textify.ps1 | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)