Wireshark · Wireshark-commits: [Wireshark-commits] master 4d2844c: Qt: do not further modify filename from Save dialog

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4d2844cceca4fdde1e293e3f404f8e820d2385b0
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4d2844c by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: do not further modify filename from Save dialog
    
    Let the Save dialog fixup the extension on accepting the dialog.
    Otherwise it is possible that files are silently overwritten without
    prompting. Additionally, if a user decides to save a pcapng file as
    "foo.pcap", do not try to rename it to "foo.pcap.pcapng".
    
    This change is limited to macOS and Linux because Windows uses a
    different file dialog. Tested with both macOS and Linux.
    
    Bug: 14600
    Change-Id: Ie0bc1f579766a04f0aad96dcd5daba3fffef9764
    Reviewed-on: https://code.wireshark.org/review/27188
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  552ef8b   Qt: improve extension selection in Save As dialog
    adds  4d2844c   Qt: do not further modify filename from Save dialog


Summary of changes:
 ui/qt/capture_file_dialog.cpp | 15 +++++++++++++++
 ui/qt/capture_file_dialog.h   |  5 ++++-
 ui/qt/main_window.cpp         |  8 ++++++++
 ui/qt/main_window.h           |  2 ++
 4 files changed, 29 insertions(+), 1 deletion(-)