Wireshark-commits: [Wireshark-commits] master-2.4 fb7f39d: Fix crash (double-free) on refreshing in
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 26 Apr 2018 16:18:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fb7f39d0b782e45e58d2e52d7cfadcc97ee18c6d
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

fb7f39d by Peter Wu (peter@xxxxxxxxxxxxx):

    Fix crash (double-free) on refreshing interfaces list
    
    When normal interfaces are unavailable (chmod -x dumpcap), and after
    toggling "Disable external capture interfaces" twice and then refreshing
    the interfaces list (F5), a double-free occurs in ui/iface_lists.c:147
    for "global_capture_opts.ifaces_err_info".
    
    Change-Id: I98697653ab1c123186892408112c34afdd1766f5
    Fixes: v1.99.0-rc1-1005-g35b4487538 ("Handle empty interface lists when the list changes.")
    Reviewed-on: https://code.wireshark.org/review/27161
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit cfc15838bdecb44ce1a17d47ad015cb9a1e8962c)
    Reviewed-on: https://code.wireshark.org/review/27169
    

Actions performed:

    from  e8fca78   build: include ui/macosx directory in dist tarball
    adds  fb7f39d   Fix crash (double-free) on refreshing interfaces list


Summary of changes:
 capchild/capture_ifinfo.c | 1 +
 1 file changed, 1 insertion(+)