Wireshark-commits: [Wireshark-commits] master 01a32a5: Qt: fix invalid member access within expert
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 20 Apr 2018 07:46:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=01a32a54a01a5711ebef0850830aed9fc9d657f6
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

01a32a5 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix invalid member access within expert info dialog
    
    Opening a context menu in the expert dialog resulted in an UBSAN warning
    because ExpertInfoModel::data is invoked with a proxy model index. Rely
    on the proxy to perform this mapping (change filterActionTriggered to
    avoid direct model access while at it).
    
    Change-Id: Id399f44b954b87d7d4dd0341fbedb391ab1b13da
    Fixes: v2.5.0rc0-1966-gb0112e60ad ("Add a model to use for Expert Info dialog.")
    Reviewed-on: https://code.wireshark.org/review/27025
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  0a130c5   Handle subset tvbuffs where the length goes past the end of the parent.
    adds  01a32a5   Qt: fix invalid member access within expert info dialog


Summary of changes:
 ui/qt/expert_info_dialog.cpp | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)