Wireshark-commits: [Wireshark-commits] master b545c60: Fix cppcheck 1.83 warnings
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 19 Apr 2018 17:31:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b545c60658143a730619df7b6c6f6df2f22e6398
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b545c60 by Alexandr Savca (s.alex08@xxxxxxx):

    Fix cppcheck 1.83 warnings
    
    [packet-ber.c:2687]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
    [packet-erf.c:2475]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
    [packet-fmp.c:378]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
    [packet-http2.c:2050]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
    [packet-obd-ii.c:643]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
    [packet-yami.c:244]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
    
    Change-Id: Ie71f9f7c8f863d1e9c693bd56444f00bdad48042
    Reviewed-on: https://code.wireshark.org/review/27019
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    

Actions performed:

    from  04aedf3   tshark: prepend tshark to all examples in doc.
    adds  b545c60   Fix cppcheck 1.83 warnings


Summary of changes:
 epan/dissectors/packet-ber.c    |  2 +-
 epan/dissectors/packet-erf.c    |  2 +-
 epan/dissectors/packet-fmp.c    |  2 +-
 epan/dissectors/packet-http2.c  | 12 ++++++------
 epan/dissectors/packet-obd-ii.c |  2 +-
 epan/dissectors/packet-yami.c   |  2 +-
 6 files changed, 11 insertions(+), 11 deletions(-)