Wireshark · Wireshark-commits: [Wireshark-commits] master-2.6 94e1c82: dfilter: require spaces as set element separator

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94e1c82f88f493c0b24fd5c19686332e9ebc7569
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

94e1c82 by Peter Wu (peter@xxxxxxxxxxxxx):

    dfilter: require spaces as set element separator
    
    Previously a filter such as `http.request.method in {"GET"HEAD""}` would
    be parsed as three strings (GET, HEAD and an empty string). As it seems
    more likely that people make typos rather than intending to construct
    such a filter, forbid this by always requiring a whitespace separator.
    
    Change-Id: I77e531fd6be072f62dd06aac27f856106c8920c6
    Reported-by: Stig Bjørlykke
    Reviewed-on: https://code.wireshark.org/review/26989
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 6a45dcd7a2ab695aade66499cdb61406a2196429)
    Reviewed-on: https://code.wireshark.org/review/27000
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  7a16851   dfilter: make spaces around ".." optional in display filter
    adds  94e1c82   dfilter: require spaces as set element separator


Summary of changes:
 epan/dfilter/dfilter-int.h |  1 +
 epan/dfilter/dfilter.c     |  1 +
 epan/dfilter/grammar.lemon |  4 ++--
 epan/dfilter/scanner.l     | 23 +++++++++++++++++++----
 4 files changed, 23 insertions(+), 6 deletions(-)