Wireshark · Wireshark-commits: [Wireshark-commits] master e4d3916: Clean up the way we handle the FCS.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4d3916530aed332fcb39d4017e633bd51c4277c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e4d3916 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up the way we handle the FCS.
    
    For the "802.15.4 with FCS" link-layer type, strip what FCS we find, if
    any, off and use that new tvbuff for all dissection except for
    checking and dissection of the FCS itself.
    
    For the "802.15.4 without FCS" link-layer type, don't fake an uncaptured
    FCS by increasing the reported length, just use the tvbuff as is.
    
    This means we handle 802.15.4 the same way we handle other link-layer
    types where the FCS might, or might not, appear as part of the captured
    data.
    
    Change-Id: Ia91b7fb0aad495876be00bf813c6b6517e5e11d7
    Reviewed-on: https://code.wireshark.org/review/26947
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  4994955   DTN: Minor changes for Bundle-Integrity/Confidentiality Block payload
    adds  e4d3916   Clean up the way we handle the FCS.


Summary of changes:
 epan/dissectors/packet-ieee802154.c | 136 ++++++++++++++++++++++++++----------
 1 file changed, 100 insertions(+), 36 deletions(-)