Wireshark-commits: [Wireshark-commits] master-2.6 73a5b4d: extcap: Always use byte mode in pipes
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 07 Apr 2018 18:02:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=73a5b4d2c0e03cd3a4f59202a928e78b0e339f61
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

73a5b4d by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    extcap: Always use byte mode in pipes
    
    The original PipeMode parameter to CreateNamedPipe() was wrong but
    when running gave a correct value. The changes in g00373a1f tried to fix
    this parameter but this gave incorrect values.
    
    Bug: 14532
    Change-Id: Ia1e8e9ba54abfcc3bd0856fd715b7c69ee54ccfe
    Reviewed-on: https://code.wireshark.org/review/26786
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    (cherry picked from commit 5d1b5648fa900319fc4d212f2fd78562959716ba)
    Reviewed-on: https://code.wireshark.org/review/26788
    

Actions performed:

    from  569ab41   Tweak ws_cpuid so that Valgrind is happy.
    adds  73a5b4d   extcap: Always use byte mode in pipes


Summary of changes:
 extcap.c | 13 ++++++-------
 extcap.h |  2 +-
 2 files changed, 7 insertions(+), 8 deletions(-)