Wireshark-commits: [Wireshark-commits] master 62af765: ZigBee: Allow a different set of attributes
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 05 Apr 2018 05:21:03 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=62af7654388645a2479193bd1a280b65c1e714e0
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

62af765 by Kenneth Soerensen (knnthsrnsn@xxxxxxxxx):

    ZigBee: Allow a different set of attributes for ZCL client and server
    
    Some clusters, for example the Smart Energy Metering cluster,
    requires a different set of attributes for the ZCL client and
    server but with overlapping IDs.
    
    This change allows to specify a different set of attributes for
    the ZCL client.
    
    To avoid breaking existing clusters that might have client attributes
    the same set of attributes are used for server and client when
    zbee_zcl_init_cluster is called.
    
    This new client attribute set is used in the Smart Energy Metering
    cluster in this commit.
    
    Change-Id: Ie25ad746dac1ccbb233ae8975ef9047d3fc6a170
    Reviewed-on: https://code.wireshark.org/review/26694
    Reviewed-by: Martin Boye Petersen <martinboyepetersen@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Paul Zander <p.j.zander@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2f44216   ZigBee: ZDP MGMT NWK Enhanced update notify
    adds  62af765   ZigBee: Allow a different set of attributes for ZCL client and server


Summary of changes:
 epan/dissectors/packet-zbee-nwk-gp.c           |   3 +-
 epan/dissectors/packet-zbee-zcl-closures.c     |  16 +-
 epan/dissectors/packet-zbee-zcl-general.c      | 257 +++++++++++++++----------
 epan/dissectors/packet-zbee-zcl-ha.c           |  19 +-
 epan/dissectors/packet-zbee-zcl-hvac.c         |  32 +--
 epan/dissectors/packet-zbee-zcl-lighting.c     |  16 +-
 epan/dissectors/packet-zbee-zcl-meas-sensing.c |  56 ++++--
 epan/dissectors/packet-zbee-zcl-misc.c         |  16 +-
 epan/dissectors/packet-zbee-zcl-sas.c          |  10 +-
 epan/dissectors/packet-zbee-zcl-se.c           | 236 +++++++++++++----------
 epan/dissectors/packet-zbee-zcl.c              | 218 ++++++++++++++-------
 epan/dissectors/packet-zbee-zcl.h              |  16 +-
 12 files changed, 558 insertions(+), 337 deletions(-)