Wireshark · Wireshark-commits: [Wireshark-commits] master 6733df6: clean up the echo dissector

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6733df6e709c1b5bda0af658f34316c92f0db4a7
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6733df6 by Martin Kaiser (wireshark@xxxxxxxxx):

    clean up the echo dissector
    
    simplify the code to distinguish between request and response
    remove the if(tree) check
    remove the offset variable, which is always 0
    reformat the code
    remove the incorrect descriptions ("echo data") for request and response
    don't modify the display filter names
    
    Change-Id: Iffe074ceef5fe2dda9e0b134a8dc4db70881d3e4
    Reviewed-on: https://code.wireshark.org/review/26667
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5ef22d4   lemon: Align struct s_options with upstream.
    adds  6733df6   clean up the echo dissector


Summary of changes:
 epan/dissectors/packet-echo.c | 56 ++++++++++++++-----------------------------
 1 file changed, 18 insertions(+), 38 deletions(-)