Wireshark-commits: [Wireshark-commits] master fdef405: cmake: fix "cmake -E env" compatibility with
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 27 Mar 2018 21:11:47 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fdef4057824ff3cfc0cd4e79b393106b73296179
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fdef405 by Peter Wu (peter@xxxxxxxxxxxxx):

    cmake: fix "cmake -E env" compatibility with older CMake
    
    "cmake -E env" was added in CMake 3.1, but we currently support 2.8.12
    at minimum. Add a best-effort replacement for older versions. There are
    some limitations from CMake (see comments), but these should not affect
    the current user (FindAsciidoctor.cmake).
    
    Change-Id: I56c92aa9ad42fb3950dbdfd955d4ff902111e0d7
    Fixes: v2.5.1rc0-76-g94a0f7c641 ("Switch from AsciiDoc to Asciidoctor.")
    Reviewed-on: https://code.wireshark.org/review/26658
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  036c5a4e  lemon: Trivial changes to make it easier to compare with upstream.
    adds  fdef405   cmake: fix "cmake -E env" compatibility with older CMake


Summary of changes:
 cmake/env.cmake                     | 76 +++++++++++++++++++++++++++++++++++++
 cmake/modules/FindAsciidoctor.cmake | 10 ++++-
 2 files changed, 84 insertions(+), 2 deletions(-)
 create mode 100644 cmake/env.cmake