Wireshark-commits: [Wireshark-commits] master b577bff: In some dialogs, have *no* auto-default butt
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 25 Mar 2018 02:16:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b577bff1ae1187471e0df2e4477b75ff548f1510
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b577bff by Guy Harris (guy@xxxxxxxxxxxx):

    In some dialogs, have *no* auto-default buttons on macOS.
    
    In macOS dialogs, there's a default button, which is the button that
    Enter/Return activates, and that Enter/Return *always* activates,
    *regardless* of what button has the input focus.  To activate the button
    that has the input focus, you use the space bar.
    
    To implement that, we need to disable auto-default on all buttons,
    including the Cancel button.
    
    Put in a comment explaining all this.
    
    We may want to do this in all alert boxes, and possibly all dialogs with
    buttons.
    
    Change-Id: I214dd2870a9720ea705d8db39adc5b6af2003fb1
    Reviewed-on: https://code.wireshark.org/review/26629
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  14fbbc8   RPC-over-RDMA: add explicit fall through comments to please gcc 7.2.0
    adds  b577bff   In some dialogs, have *no* auto-default buttons on macOS.


Summary of changes:
 ui/qt/capture_file_dialog.cpp | 26 +++++++++++++++++++++++++-
 ui/qt/main_window.cpp         | 29 ++++++++++++++++++++++++++++-
 2 files changed, 53 insertions(+), 2 deletions(-)