Wireshark-commits: [Wireshark-commits] master b4b3749: Fix a comment.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 24 Mar 2018 03:34:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b4b374937f33368cbf06aaedb7f22448076d47fb
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b4b3749 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix a comment.
    
    We already *have* an exported dissector that always dissects PPP without
    HDLC-like framing; the question is whether we should have one that
    always dissects PPP with HDLC-like framing (with a check for the
    HDLC-like framing, in case, for example, it was negotiated away), but
    doesn't check for Cisco HDLC.
    
    Change-Id: I3b3319dd29c7516220b82df626bc6ac520ea0dd9
    Reviewed-on: https://code.wireshark.org/review/26622
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  0f34a86   Hand off to the PPC-in-HDLC-like-framing dissector.
    adds  b4b3749   Fix a comment.


Summary of changes:
 epan/dissectors/packet-ppp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)