Wireshark-commits: [Wireshark-commits] master-2.4 cacf868: Don't rely on "xxx *yyy[N] = {}; " compi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 24 Mar 2018 02:33:43 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cacf8687a0a046d95744801c7fc20bac0d6ba270
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

cacf868 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't rely on "xxx *yyy[N] = {};" compiling.
    
    At least as I read C90 "6.5.7 Initialization" and C99 "6.7.8
    Initialization", there must be at least one "initializer" in an
    "initializer-list", so nothing requires that the compiler accept, for
    example
    
    	static const ws_mem_usage_t *memory_components[MAX_COMPONENTS] = {
    	};
    
    Bug: 14556
    Change-Id: Ief1dbfee504ad5ef1d984390dc2da18deba7fb90
    Reviewed-on: https://code.wireshark.org/review/26616
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit bff1f7f70e354d5e5b5f47bed87b996c538a3633)
    Reviewed-on: https://code.wireshark.org/review/26617
    

Actions performed:

    from  8018591   Use $(INSTALL_DATA) rather than "install -m 644".
    adds  cacf868   Don't rely on "xxx *yyy[N] = {};" compiling.


Summary of changes:
 epan/app_mem_usage.c | 47 +++++++++++++++++++----------------------------
 1 file changed, 19 insertions(+), 28 deletions(-)